Skip to content

Skip colors on travis job#1034

Merged
dunglas merged 1 commit into
api-platform:2.0from
soyuka:2.0
Apr 7, 2017
Merged

Skip colors on travis job#1034
dunglas merged 1 commit into
api-platform:2.0from
soyuka:2.0

Conversation

@soyuka

@soyuka soyuka commented Apr 6, 2017

Copy link
Copy Markdown
Member

They disabled logs when nb_lines > 10000, which is our case, this helps
debugging

Q A
Bug fix? no
New feature? yes \o/
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets na
License MIT
Doc PR na

They disabled logs when nb_lines > 10000, which is our case, this helps
debugging
@dunglas
dunglas merged commit 1c78361 into api-platform:2.0 Apr 7, 2017
@dunglas

dunglas commented Apr 7, 2017

Copy link
Copy Markdown
Member

Thanks @soyuka

@teohhanhui

Copy link
Copy Markdown
Contributor

Probably a better fix would be to reduce the verbosity of some of the installation logs. Colours are good...

@soyuka

soyuka commented Apr 18, 2017

Copy link
Copy Markdown
Member Author

Behat alone is >10k lines no?

@teohhanhui

Copy link
Copy Markdown
Contributor

Okay, now I'm not sure I get what this PR is supposed to do... \o/

@soyuka

soyuka commented Apr 20, 2017

Copy link
Copy Markdown
Member Author

I don't remember what PR it was but the author was asking for help debugging. I had to fork his branch to execute the tests on my device because travis output was unreadable because colors where stripped. Can't find the reference, but travis clearly stated that above 10 000 lines, colors won't be outputted and we'll instead get ASCII characters.

@teohhanhui

Copy link
Copy Markdown
Contributor

I think Travis stops showing log output when it hits 10000 lines (it's still available in the raw log). The way mozilla/fxa-content-server#488 handled it (reducing verbosity where unneeded) seems better to me.

@teohhanhui

Copy link
Copy Markdown
Contributor

@soyuka

soyuka commented Apr 20, 2017

Copy link
Copy Markdown
Member Author

Damn, I need to get my hand on the screenshot again. Anyway, if you really want colors back we can revert this ^^ but it's not a priority imo.

@teohhanhui

teohhanhui commented Apr 20, 2017

Copy link
Copy Markdown
Contributor

No colours = hard to read. Symfony uses colours too... 😛

https://github.com/symfony/symfony/blob/59f3f34cc84e93e287e0971d05bfe0edee8e20e2/.travis.yml

@soyuka

soyuka commented Apr 20, 2017

Copy link
Copy Markdown
Member Author

No colours = hard to read.

Many unix users would actually tell you that it is more a distraction 😛 . Thing is, it's way more readable than when colors are ASCII outputed no?

hoangnd25 pushed a commit to hoangnd25/core that referenced this pull request Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants